From 9de669e32e8dc4a71696c2f5324c1078768413f9 Mon Sep 17 00:00:00 2001 From: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Date: Fri, 10 Nov 2023 12:43:48 +0400 Subject: [PATCH] chore: clean up workflow and added PR desc template (#5895) --- .github/translation_sync_template.md | 9 +++++++++ .github/workflows/translation-sync.yml | 5 ++--- 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 .github/translation_sync_template.md diff --git a/.github/translation_sync_template.md b/.github/translation_sync_template.md new file mode 100644 index 00000000000..3e1ba4d9663 --- /dev/null +++ b/.github/translation_sync_template.md @@ -0,0 +1,9 @@ +## 🤖 Automated Translation Pull Request +This is an automated pull request to fetch the newly translated strings from `Crowdin` to ensure +that we do not overwrite the translations provided by the translation team before pushing our new strings. + +## 📝 Note: +- It is recommended to merge this PR immediately to minimize the risk of conflicts, although the likelihood of conflicts is very low. +- In the event of a missed merge and another PR is merged into the master branch, this PR will be automatically deleted, and a new one with the latest updates will be created. +- Prior to creating this PR, the translations from the master branch and Crowdin are synchronized and sent to Crowdin for the latest updates. +- This PR is essential for updating our codebase with the synchronized version sent to Crowdin, ensuring that both platforms have the same working copy. \ No newline at end of file diff --git a/.github/workflows/translation-sync.yml b/.github/workflows/translation-sync.yml index 7d3aaddbb9e..ac96cd56c28 100644 --- a/.github/workflows/translation-sync.yml +++ b/.github/workflows/translation-sync.yml @@ -51,7 +51,6 @@ jobs: # Commit the newly downloaded files cd $(git rev-parse --show-toplevel) - echo "GIT STATUS: $(git status --porcelain)" git add . git commit -m "translations: 📚 sync translations with crowdin" @@ -61,7 +60,7 @@ jobs: sudo apt install gh gh auth login --with-token <<< ${{ github.token }} gh pr close "$branch_name" || true - gh pr create --base "master" --title "[Translations] New strings from crowdin 📚" --head "binary-com:$branch_name" --body "This is an automated pull request to fetch the newly translated strings from Crowdin to ensure that we do not overwrite the translations provided by the translation team before pushing our new strings." + gh pr create --base "master" --title "[translations] New strings from crowdin 📚" --head "binary-com:$branch_name" -F ".github/translation_sync_template.md" fi # Upload new strings to Crowdin @@ -75,7 +74,7 @@ jobs: { attachments: [{ color: '${{ job.status }}' === 'success' ? 'good' : '${{ job.status }}' === 'failure' ? 'danger' : 'warning', - text: `*[Deriv.com]* New strings are pushed to crowdin master branch:(https://crowdin.com/project/deriv-com/content/files)` + text: `*[Deriv.com]* strings are synced to crowdin master branch:(https://crowdin.com/project/deriv-com/content/files)` }] } env: