From c7be2ce33ae012c3af05167fddc3b09227ff9ea1 Mon Sep 17 00:00:00 2001 From: wei liu Date: Thu, 23 May 2024 18:15:41 +0800 Subject: [PATCH] enhance: Decrease bloom filter fp rate to reduce delete impact (#33301) when milvus process delete record, it need to find record's corresponded segment by bloom filter, and higher bloom filter fp rate will cause delete record forwards to wrong segments. This PR Decrease bloom filter's default fp to 0.001. Signed-off-by: Wei Liu --- configs/milvus.yaml | 2 +- pkg/util/paramtable/component_param.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index 6cf78cc058e63..5410ecce75b15 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -612,7 +612,7 @@ common: ttMsgEnabled: true # Whether the instance disable sending ts messages traceLogMode: 0 # trace request info bloomFilterSize: 100000 # bloom filter initial size - maxBloomFalsePositive: 0.05 # max false positive rate for bloom filter + maxBloomFalsePositive: 0.001 # max false positive rate for bloom filter # QuotaConfig, configurations of Milvus quota and limits. # By default, we enable: diff --git a/pkg/util/paramtable/component_param.go b/pkg/util/paramtable/component_param.go index 8804240da4ef9..735987f994159 100644 --- a/pkg/util/paramtable/component_param.go +++ b/pkg/util/paramtable/component_param.go @@ -728,7 +728,7 @@ like the old password verification when updating the credential`, p.MaxBloomFalsePositive = ParamItem{ Key: "common.maxBloomFalsePositive", Version: "2.3.2", - DefaultValue: "0.05", + DefaultValue: "0.001", Doc: "max false positive rate for bloom filter", Export: true, }