Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side script initialization not practical #12

Open
Swaagie opened this issue Jul 30, 2014 · 4 comments
Open

Client side script initialization not practical #12

Swaagie opened this issue Jul 30, 2014 · 4 comments

Comments

@Swaagie
Copy link
Member

Swaagie commented Jul 30, 2014

The client side script intialization being tied into the naming of the pagelet is a destructive pattern. Consider using the same pagelet two times, but with template content that is slightly different, hence you extend either of the two and choose a unique name. However that also means you now have to rewrite the client script, cumbersome.

@3rd-Eden
Copy link
Member

Will be fixed one sandboxing is implemented as the source of the js file will be stored as string and evaluated once the pagelet is loaded.

Arnout Kazemier

On Jul 30, 2014, at 13:29, Martijn Swaagman [email protected] wrote:

The client side script intialization being tied into the naming of the pagelet is a destructive pattern. Consider using the same pagelet two times, but with template content that is slightly different, hence you extend either of the two and choose a unique name. However that also means you now have to rewrite the client script, cumbersome.


Reply to this email directly or view it on GitHub.

@Swaagie
Copy link
Member Author

Swaagie commented Jul 30, 2014

Sure I just needed a mental note. While working on the npm interface I encountered some stuff I'd like us to discuss and I also know see why you opted for certain changes

@3rd-Eden
Copy link
Member

We shall engage in an epic debate once I return.

Arnout Kazemier

On Jul 30, 2014, at 21:23, Martijn Swaagman [email protected] wrote:

Sure I just needed a mental note. While working on the npm interface I encountered some stuff I'd like us to discuss and I also know see why you opted for certain changes


Reply to this email directly or view it on GitHub.

@Swaagie
Copy link
Member Author

Swaagie commented Jul 31, 2014

I do not expect you to read this anyways, shoooo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants