Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should childs re-render when parents render #8

Open
3rd-Eden opened this issue Jun 13, 2014 · 1 comment
Open

Should childs re-render when parents render #8

3rd-Eden opened this issue Jun 13, 2014 · 1 comment

Comments

@3rd-Eden
Copy link
Member

Currently when you parent pagelet and it re-renders the layout the childs will not re-render. This needs to be done manually. It might make more sense to have the child pagelets listen to parent's render event and trigger a render after that.

As an additional optimization we could be given the new DOM tree, and modify that before it's added to the root element of the parent node so we have to do less DOM manipulation. Of course this wouldn't be needed if we adopted something like a shadow/virtual dom.

@3rd-Eden
Copy link
Member Author

First part was fixed with: cbb31eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant