Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore private variables #13

Open
Swaagie opened this issue Mar 13, 2015 · 0 comments
Open

Underscore private variables #13

Swaagie opened this issue Mar 13, 2015 · 0 comments

Comments

@Swaagie
Copy link
Member

Swaagie commented Mar 13, 2015

To stay in line with the server side part of bigpipe, we should underscore private variabeles. This should also allow 'collision free' property usage for client side plugins.

Currently the following would fail in client side pagelets due to not having _bigpipe on the client side. This would go for all general modules or constructors that are used isomorphic.

function DataStore(pagelet) {
  if (!this) return new DataStore(pagelet);

  this.readable('_pagelet', pagelet);
  this.readable('_pouchdb', pagelet._bigpipe.pouchdb);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant