Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desc_id -> description_id and have values with desc- prefix #79

Open
2 tasks
yarikoptic opened this issue May 31, 2024 · 2 comments
Open
2 tasks

desc_id -> description_id and have values with desc- prefix #79

yarikoptic opened this issue May 31, 2024 · 2 comments
Labels
consistency Aspect requiring special treatment/logic outside of generic common principles

Comments

@yarikoptic
Copy link
Contributor

came up in the course of

_ids which are named for 3 out of 4 {entitylongname}_id (and value is {entityshortname}-{value} )

❯ grep '_id:$' objects/columns.yaml
desc_id:
participant_id:
sample_id:
session_id:

but I guess could be generalized for any entity (context: #54 ).

I think we should harmonize desc_id -> description_id and ensure we have value to be desc-{label} not just {label} as it is now in https://github.com/bids-standard/bids-specification/blob/master/src/derivatives/common-data-types.md?plain=1#L331 .

ATTN @bids-standard/bep016 folks (no team yet, sorry, hence @CPernet @tsalo as added/touched relevant stuff)

TODOs

  • fixup for desc_id -> description_id within bids 2.0 branch
  • formulate it as a "common principle" that for any entity there could be {entitylongname}_id in a corresponding {entitylongnameplural}.tsv .
@yarikoptic yarikoptic added the consistency Aspect requiring special treatment/logic outside of generic common principles label May 31, 2024
@effigies
Copy link

@bids-standard/derivatives-mri-dwi Would probably be the BEP16 team.

@yarikoptic yarikoptic moved this to Todo in BIDS 2.0 May 31, 2024
@Lestropie
Copy link

Not sure if BEP016 is the right ping here; not doing anything in particular with _desc- there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Aspect requiring special treatment/logic outside of generic common principles
Projects
Status: Todo
Development

No branches or pull requests

3 participants