Start validating version in CI (DataDog#18077)

* Start validating version in CI * Fix changelogs and ignore ddev
bhargavnariyanicrest · Jul 20, 2024 · 70537a4 · 70537a4
1 parent 1f0af38
commit 70537a4
Show file tree

Hide file tree

Showing 50 changed files with 267 additions and 61 deletions.
diff --git a/.github/workflows/run-validations.yml b/.github/workflows/run-validations.yml
@@ -102,6 +102,10 @@ on:
         required: false
         default: false
         type: boolean
+      version:
+        required: false
+        default: false
+        type: boolean
 
 defaults:
   run:
@@ -231,6 +235,10 @@ jobs:
       if: inputs.labeler
       run: ddev validate labeler
 
+    - name: Validate target version
+      if: inputs.version
+      run: ddev validate version $TARGET
+
     # Every validation below here is sorted by increasing runtime rather than alphabetically
     - name: Validate third-party license metadata
       if: inputs.licenses

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -38,4 +38,5 @@ jobs:
       readmes: true
       saved-views: true
       service-checks: true
+      version: true
     secrets: inherit
diff --git a/agent_metrics/CHANGELOG.md b/agent_metrics/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Agent Metrics
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/amazon_eks/CHANGELOG.md b/amazon_eks/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Amazon EKS
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/amazon_eks_blueprints/CHANGELOG.md b/amazon_eks_blueprints/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - amazon_eks_blueprints
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/azure_active_directory/CHANGELOG.md b/azure_active_directory/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Azure Active Directory
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/cisco_duo/CHANGELOG.md b/cisco_duo/CHANGELOG.md
@@ -1,9 +1,7 @@
 # CHANGELOG - cisco_duo
 
-<!-- towncrier release notes start -->
-
 ## 1.0.0 / 2024-01-31
 
 ***Added***:
 
-* Initial Release
+* Initial Release
diff --git a/cisco_sdwan/CHANGELOG.md b/cisco_sdwan/CHANGELOG.md
@@ -1,4 +1,8 @@
 # CHANGELOG - Cisco SD-WAN
 
-<!-- towncrier release notes start -->
 
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/cisco_umbrella_dns/CHANGELOG.md b/cisco_umbrella_dns/CHANGELOG.md
@@ -1,8 +1,6 @@
 # CHANGELOG - cisco_umbrella_dns
 
-<!-- towncrier release notes start -->
-
-1.0.0 / 2024-01-01
+## 1.0.0 / 2024-01-01
 
 ***Added***:
 

diff --git a/consul_connect/CHANGELOG.md b/consul_connect/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Consul Connect
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/container/CHANGELOG.md b/container/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Container
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/containerd/CHANGELOG.md b/containerd/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Containerd
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/cri/CHANGELOG.md b/cri/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - CRI
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/databricks/CHANGELOG.md b/databricks/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Databricks
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/datadog_operator/CHANGELOG.md b/datadog_operator/CHANGELOG.md
@@ -1,7 +1,5 @@
 # CHANGELOG - Datadog Operator
 
-<!-- towncrier release notes start -->
-
 ## 1.0.0 / 2023-03-30
 
 ***Added***:

diff --git a/ddev/src/ddev/cli/validate/version.py b/ddev/src/ddev/cli/validate/version.py
@@ -112,11 +112,14 @@ def version(ctx: click.Context, integrations: tuple[str, ...]):
     if not integrations:
         integrations = ('all',)
 
-    for current_check in app.repo.integrations.iter_all(selection=integrations):
-        changelog = current_check.path / 'CHANGELOG.md'
-        version_file = current_check.package_directory / '__about__.py'
+    for project in app.repo.integrations.iter_all(selection=integrations):
+        # ddev manages its version dynamically.
+        if project.name == 'ddev':
+            continue
+        changelog = project.path / 'CHANGELOG.md'
+        version_file = project.package_directory / ('_version.py' if project.name == 'ddev' else '__about__.py')
         is_python_pkg = version_file.exists()
-        track_err = partial(tracker.error, (current_check.name,))
+        track_err = partial(tracker.error, (project.name,))
 
         if is_python_pkg and not changelog.exists():
             track_err(message=f'This looks like a Python package, but {changelog.relative_to(repo_path)} is missing.')
@@ -126,12 +129,14 @@ def version(ctx: click.Context, integrations: tuple[str, ...]):
 
         if is_python_pkg:
             validate = _validate_python_package
-        else:
+        elif project.is_tile:
             validate = _validate_tile_only_int
+        else:
+            continue
         validate(
             track_err,
             repo_path,
-            current_check,
+            project,
             version_file,
             changelog,
             changelog_is_autogenerated,

diff --git a/docker_daemon/CHANGELOG.md b/docker_daemon/CHANGELOG.md
@@ -1,7 +1,5 @@
 # CHANGELOG - docker_daemon
 
-<!-- towncrier release notes start -->
-
 ## 1.12.0 / 2020-01-13
 
 ***Added***:

diff --git a/eks_anywhere/CHANGELOG.md b/eks_anywhere/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Amazon EKS Anywhere
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/gke/CHANGELOG.md b/gke/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Google Kubernetes Engine
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/go-metro/CHANGELOG.md b/go-metro/CHANGELOG.md
@@ -1,7 +1,5 @@
 # CHANGELOG - go-metro
 
-<!-- towncrier release notes start -->
-
 ## 1.3.1 / 2021-03-07
 
 ***Fixed***:

diff --git a/helm/CHANGELOG.md b/helm/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Helm
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/iam_access_analyzer/CHANGELOG.md b/iam_access_analyzer/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Iam Access Analyzer
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/jmeter/CHANGELOG.md b/jmeter/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - JMeter
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/kubernetes/CHANGELOG.md b/kubernetes/CHANGELOG.md
@@ -1,7 +1,5 @@
 # CHANGELOG - kubernetes
 
-<!-- towncrier release notes start -->
-
 ## 1.7.0 / 2020-05-17
 
 ***Added***:

diff --git a/kubernetes_state_core/CHANGELOG.md b/kubernetes_state_core/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Kubernetes State Core
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/ntp/CHANGELOG.md b/ntp/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - NTP
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/nvidia_jetson/CHANGELOG.md b/nvidia_jetson/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Nvidia Jetson
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/oke/CHANGELOG.md b/oke/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Oracle Container Engine for Kubernetes - OKE
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/oom_kill/CHANGELOG.md b/oom_kill/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - OOM Kill
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/openai/CHANGELOG.md b/openai/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - OpenAI
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/openshift/CHANGELOG.md b/openshift/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - OpenShift
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/otel/CHANGELOG.md b/otel/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - OTel
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/pivotal_pks/CHANGELOG.md b/pivotal_pks/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Pivotal PKS
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.
diff --git a/podman/CHANGELOG.md b/podman/CHANGELOG.md
@@ -1,3 +1,8 @@
 # CHANGELOG - Podman
 
-<!-- towncrier release notes start -->
+
+## 1.0.0
+
+***Added***:
+
+* Initial release.