Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GN (Generate Ninja) filetype #365

Open
thiagowfx opened this issue Dec 22, 2022 · 3 comments
Open

Add GN (Generate Ninja) filetype #365

thiagowfx opened this issue Dec 22, 2022 · 3 comments

Comments

@thiagowfx
Copy link

https://github.com/beyondgrep/ack3/blob/dev/CONTRIBUTING.md:

  • The name of the filetype: GN (Generate Ninja)
    What the definition of the filetype would be, taken from the .ackrc file that you've been using: .gn, .gni
  • URL of a web page that discusses what the filetype is: https://gn.googlesource.com/gn/
  • What the file contains, and why it should be a filetype: GN is a meta-build system that generates build files for Ninja.
  • How widely used this filetype will be: It's widely used in Chromium and it's very similar to https://bazel.build/.

Patch: https://github.com/thiagowfx/ack3/commit/7aabc0ac3bcda3a2c1192cffd337f3f33cd361f3

I didn't submit a PR to this repo because of the instructions in CONTRIBUTING.md requested to file an issue first.

@petdance
Copy link
Collaborator

So it sounds like this roughly analogous to a Makefile, right?

How long have you been using it? Are you typically searching for something in them, or excluding GN files?

@petdance
Copy link
Collaborator

Also: It makes me happy to see folks reading the docs. :-)

@thiagowfx
Copy link
Author

So it sounds like this roughly analogous to a Makefile, right?

It's a bit more complicated than that, as the files are often composed together. If you were to compare it with a Makefile, I'd say it's similar to cmake / CMakeLists.txt in the sense that in a single project you tend to find many of them scattered around the codebase.

How long have you been using it?

Since early August, apparently! thiagowfx/.dotfiles@dcc2568

Are you typically searching for something in them, or excluding GN files?

Typically searching for something in them, like a buildflag or a variable. Something like: ack --gn is_chrome_for_testing or ack --gn executable\( or ack --gn browser_tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants