Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manycore Origin Hardcoded, Inaccurate Parameter Name #853

Open
gaozihou opened this issue Dec 6, 2024 · 0 comments · May be fixed by #855
Open

Manycore Origin Hardcoded, Inaccurate Parameter Name #853

gaozihou opened this issue Dec 6, 2024 · 0 comments · May be fixed by #855
Assignees

Comments

@gaozihou
Copy link
Contributor

gaozihou commented Dec 6, 2024

https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/libraries/bsg_manycore_config_pod.h#L56
https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/libraries/bsg_manycore_config_pod.h#L65

Should obtain origin by calling hb_mc_config_get_origin(cfg) or hb_mc_config_get_origin_vcore(cfg), which is set by machine variables BSG_MACHINE_ORIGIN_COORD_X and BSG_MACHINE_ORIGIN_COORD_Y:
https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/machines/pod_X1Y1_ruche_X16Y8_hbm_one_pseudo_channel/Makefile.machine.include#L113-L115

Also, the following pod_id parameter names are inaccurate, should be pod instead since they are coordinates, not indices
https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/libraries/bsg_manycore_config_pod.h#L73-L129

@gaozihou gaozihou self-assigned this Dec 6, 2024
@gaozihou gaozihou changed the title Manycore Origin Hardcoded Manycore Origin Hardcoded, Inaccurate Parameter Name Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant