-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor PPA improvement in Load Packer #507
Comments
Sounds like a task for @LaurenChoquer |
I think rewriting the entire module so that bit-by-bit (or groups of bits)
we define the output could pay some dividends. Modifying the if then else
statement along I am less certain. Probably worth looking at what
synthesis is doing first though.
M
…On Fri, Apr 9, 2021 at 9:03 AM Dustin Richmond ***@***.***> wrote:
Sounds like a task for @LaurenChoquer <https://github.com/LaurenChoquer>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#507 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFG5AFX224S43SIJIL3GQLTH4QNFANCNFSM42UAKQ5A>
.
|
Yeah we saw an improvement switching to one-hot for a very similar path bp. If we get a better result with bit muxing, will definitely implement it there too (this is the current critical path) |
Oh maybe share the link to the refactored module for Lauren
…On Fri, Apr 9, 2021 at 10:10 AM Dan Petrisko ***@***.***> wrote:
Yeah we saw an improvement switching to one-hot for a very similar path
bp. If we get a better result with bit muxing, will definitely implement it
there too (this is the current critical path)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#507 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFG5AE7FG6LCYGMHVBQ2L3TH4YHLANCNFSM42UAKQ5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/vanilla_bean/load_packer.v#L50
Could be made a one-hot mux, since an op will only have 1 size at a time
The text was updated successfully, but these errors were encountered: