Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release Java 23 compatible version #275

Closed
xzel23 opened this issue Sep 19, 2024 · 5 comments
Closed

release Java 23 compatible version #275

xzel23 opened this issue Sep 19, 2024 · 5 comments

Comments

@xzel23
Copy link
Collaborator

xzel23 commented Sep 19, 2024

The Plugin currently (version 3.0.1) fails to work on projects with JDK 23. There's already an unmerged PR that addresses this: #271

I add this new issue to describe a workaround until a new version is released.

Workaround until new plugin version is released

NOTE: This only works when using the plugin on your local machine, so it is rather a "works-for-me" hack than a general solution.

  1. Check out the plugin code and apply the PR mentioned above.
  2. Change the plugin version (I used 3.0.2).
  3. build using ./gradlew build publishToMavenLocal publishJlinkPluginMarkerMavenPublicationToMavenLocal publishPluginMavenPublicationToMavenLocal (I am not sure if the latter two targets are really necessary)
  4. Create/edit your ~/.gradle/init.gradle to contain the following text:
settingsEvaluated { settings ->
    settings.pluginManagement {
        repositories {
            mavenLocal()
            gradlePluginPortal()
        }
    }
}
gradle.settingsEvaluated { settings ->
    settings.buildscript.repositories {
        mavenLocal()
        mavenCentral()
        gradlePluginPortal()
    }
}
  1. Update the plugin version in the project you want to use the patched plugin in
@xzel23
Copy link
Collaborator Author

xzel23 commented Sep 21, 2024

Sorry. I used the wrong filename. It's not ~/.gradle/gradle.init but ~/.gradle/init.gradle. Corrected it in the workaround description.

@CodeDead
Copy link

CodeDead commented Nov 4, 2024

Hi @xzel23 , thanks for your patch and for keeping this plugin alive single handed! I've added your fork repository to the credits of my app!

https://github.com/CodeDead/opal/tree/development?tab=readme-ov-file#dependencies

@xzel23
Copy link
Collaborator Author

xzel23 commented Nov 5, 2024

Thank you too. Actually I think we will see an updated version of the original plugin soon. Stay tuned!

@xzel23
Copy link
Collaborator Author

xzel23 commented Nov 6, 2024

Fixed with 3.1.0-rc-1. I have also successfully tested with Java 24 EA (you must have it installed locally and use a toolchain since Gradle does not support Java 24 yet).

@xzel23 xzel23 closed this as completed Nov 6, 2024
@CodeDead
Copy link

CodeDead commented Nov 6, 2024

Fixed with 3.1.0-rc-1. I have also successfully tested with Java 24 EA (you must have it installed locally and use a toolchain since Gradle does not support Java 24 yet).

Works like a charm! Thanks @xzel23 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants