Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop (Rules) #68

Open
11 of 18 tasks
martinst06 opened this issue Apr 29, 2024 · 1 comment · May be fixed by #67
Open
11 of 18 tasks

Loop (Rules) #68

martinst06 opened this issue Apr 29, 2024 · 1 comment · May be fixed by #67
Assignees
@martinst06
Labels
enhancement New feature or request

Comments

@martinst06
Copy link
Collaborator

martinst06 commented Apr 29, 2024 •
edited
Loading

  • Define column names with the team
  • Fake rules json file

To do:

  • Getting the json list
  • Parsing the json list and handling json errors

Classes

  • Separate Services and the Rules
  • Define Accessors
  • Define the different sensors
  • Getting the correct data for each sensor
  • Get the correct rule by it's id (Change from fixed data to a variable)
  • Add scheduling / cron tab/job
  • "Range" logic
  • Use current data
  • Ensure that all requirements are met before executing actions
  • Execute Actions (e.g. water zone, water pot, etc.)

Little issues

  • Revisit min's and max's (soilTemp, soilMoist. etc.)
  • Fix Port 9000 PID issue
  • Change query limit from 14 to total amount of sensors (e.g. sensorAmount = len(sensorList))
  • On first iteration in the cli, an empty list is returned. Get rid of the empty list
@martinst06 martinst06 self-assigned this Apr 29, 2024
@martinst06 martinst06 added the enhancement New feature or request label Apr 29, 2024
@martinst06 martinst06 linked a pull request Apr 29, 2024 that will close this issue
Loop #67
Open
@martinst06
Copy link
Collaborator Author

martinst06 commented Jun 6, 2024 •
edited
Loading

Questions

How do we extract the rule?
Either:

  1. By the id of the rule
  2. Getting the rule that was added first (the oldest) in queue

What happens if the rule can't be applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinst06 martinst06

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loop berufsbildung-basel/awmps
1 participant
@martinst06