-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemonize sending #7
base: master
Are you sure you want to change the base?
Conversation
@@ -37,3 +37,5 @@ | |||
end | |||
end | |||
|
|||
Hermes::Configuration.instance.load! | |||
CONFIG = Hermes::Configuration.instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use Hermes::Configuration.instance
whenever you want the config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because it's shorter :)
@atombender Are we good to go? This branch won't cause problems for any of your Hermes clients? |
I don't know about your apps, but that's a design flaw one should avoid and which is easily avoided by carefully using the appropriate events that represent intent. For example, the Hermes API, after creating a Grove document, could post an event Other than that, I think your changes are fine. |
Also refactor the handling of pebblebed connectors.