Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot extract enough nodes using SBS #25

Open
Carrieww opened this issue Aug 25, 2023 · 1 comment
Open

Cannot extract enough nodes using SBS #25

Carrieww opened this issue Aug 25, 2023 · 1 comment

Comments

@Carrieww
Copy link

Hi, I am working on movielens-1m dataset. SnowBallSampler will never stop when num_of_nodes is high (e.g. 50% of nodes) (I fixed the seed=2022 and k=50 by default). During debugging, I noticed self._queue in line 72 of snowballsampler.py is empty, as shown in the attachment. Therefore, the while loop will never stop. It would be nice to add an exception telling people that the sampler can only extract xxx nodes < num_of_nodes and advise people to increase the parameter k.

In my case, only 5049 nodes can be extracted using SnowBallSampler while num_of_nodes = 5200.

Screenshot 2023-08-25 at 10 56 16
@rjurney
Copy link
Contributor

rjurney commented Jan 17, 2024

How can we know the maximum number reachable without trying it? You mean just stop and throw an exception if the number is constant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants