Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is php 8 compatible only won't run on php7.4 #9

Closed
gm-lunatix opened this issue Feb 7, 2022 · 2 comments
Closed

Code is php 8 compatible only won't run on php7.4 #9

gm-lunatix opened this issue Feb 7, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gm-lunatix
Copy link

Is your feature request related to a problem? Please describe.
First of all great package. Unfortunately it won't run on php7.4. Since the code is full of php 8 only features (constructor property promotion, 'mixed' type hinting in function argument i.e. String|Null or using match() ), you should force php v8 in the composer config file.

Describe the solution you'd like
A perfect solution would be to add php 7.4 compatibility.

Additional context
Global usage based on the packagist stats (https://stitcher.io/blog/php-version-stats-january-2022) still favors 7.x more than 50% of the time over 8.x Most laravel apps written in php7 and already live won't get the php8 upgrade option anytime soon, that's just how production app lifetime is.

@gm-lunatix gm-lunatix added the enhancement New feature or request label Feb 7, 2022
@bendeckdavid bendeckdavid self-assigned this Feb 9, 2022
@bendeckdavid bendeckdavid pinned this issue Feb 9, 2022
@bendeckdavid
Copy link
Owner

Hi @gm-lunatix you got a really good point, I think the package should offer support for php 7.0+, next version will include it.

@arneprescher
Copy link

I would also be very happy about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants