fix: 224 action hangs in some cases for go fiber benchmarks #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix reExtract regexp to avoid catastrophic backtracking * add test cases from fiber that were causing issues
…le metrics in Go but they were not extracted properly before v1.18.0
ktrz
commented
Feb 1, 2024
| @@ -353,7 +353,7 @@ function extractGoResult(output: string): BenchmarkResult[] { | |||
| // "A benchmark result line has the general form: <name> <iterations> <value> <unit> [<value> <unit>...]" | |||
| // "The fields are separated by runs of space characters (as defined by unicode.IsSpace), so the line can be parsed with strings.Fields. The line must have an even number of fields, and at least four." | |||
| const reExtract = | |||
| /^(?<name>Benchmark\w+(?:\/?[\w()$%^&*-=,]*?)*?)(?<procs>-\d+)?\s+(?<times>\d+)\s+(?<remainder>.+)$/; | |||
| /^(?<name>Benchmark\w+[\w()$%^&*-=|,[\]{}"#]*?)(?<procs>-\d+)?\s+(?<times>\d+)\s+(?<remainder>.+)$/; | |||
There was a problem hiding this comment.
This adds some additional characters that were present in Go Fiber benchmarks as well as removes the nested (()*?)*? which was causing the regex to hang in some instances
ktrz
commented
Feb 1, 2024
| @@ -209,6 +209,12 @@ describe('extractResult()', function () { | |||
| value: 40537.456, | |||
| extra: '30001 times', | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
This is the backward compatible metric as before v1.18.0 it was resulting like that in case of multiple metrics
ningziwen
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #224