You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
Hi there ! First, thank you for this very useful plugin.
The latest release v1.0.2 added (fixed) the possibility to override values upon push.
The problem is that by rewriting values.yaml, all comments and new lines are stripped from the file.
This is very problematic as it goes against Helm good practices.
Example of values.yaml pushed using 1.0.1:
# @Copyright YYY# This file defines the default values used by the XX-library.# To reference them in your own Chart templates, use `.Values.XXX`.# To override any of them in your own values.xml, do not forget the "XX" key.# name of the project, this is requiredproject: null# some other property, blabla documentationother: 12
The same values.yaml pushed to artifactory using 1.0.2:
project:nullother: 12
I understand keeping comments makes the override of values difficult.
However, I would expect that if I don't use the override feature (not -s options passed), the values.yaml should be pushed unchanged.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi there ! First, thank you for this very useful plugin.
The latest release v1.0.2 added (fixed) the possibility to override values upon push.
The problem is that by rewriting
values.yaml
, all comments and new lines are stripped from the file.This is very problematic as it goes against Helm good practices.
Example of values.yaml pushed using 1.0.1:
The same values.yaml pushed to artifactory using 1.0.2:
I understand keeping comments makes the override of values difficult.
However, I would expect that if I don't use the override feature (not
-s
options passed), the values.yaml should be pushed unchanged.The text was updated successfully, but these errors were encountered: