Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op16_no03: vhv does not render staff placement properly due to clef change around spine split #41

Open
bel28kent opened this issue Apr 5, 2024 · 2 comments
Labels
vhv-viz-bug This issue concerns a bug in VHV visualization of kern.

Comments

@bel28kent
Copy link
Owner

Screen Shot 2024-04-05 at 12 27 44 PM
@bel28kent bel28kent added the vhv-viz-bug This issue concerns a bug in VHV visualization of kern. label Apr 5, 2024
@craigsapp
Copy link
Contributor

craigsapp commented Apr 11, 2024

Yes to the comment in another isusse: I currently require the clef change to be in the first subspine (leftmost) for the staff (I think that I will drop that requirement, which will allow you to encode are you are currently doing). An easy solution would be to include the clef change in all subspines for the staff:

Screenshot 2024-04-10 at 6 31 35 PM

[View in VHV]

I did the limitation since there was one visible clef, and I didn't want the confusing case where two different clefs were encoded in the subspines.

But It would be good to adjust the converter to allow for your cases using flipper. Doing a clef change in all subspines is useful for extracting subspines:

Screenshot 2024-04-10 at 6 35 39 PM

[View in VHV]

Here I separate the two subspines into separat staves. In order to preserved clef changes in both staves, it has to be in both subspines (so that still might be the best way to encode, which allows viewing the voices on separate staves (or also useful for some types of analyses where you want to deal single-voice spines).

Screenshot 2024-04-10 at 6 40 50 PM

[View in VHV]

I also have an option -Mr which should replace primary spine notes with rests for cases where you do not want to duplicate notes in the primary spine in the secondary spine (but it is not working, so I will have to fix it).

@bel28kent
Copy link
Owner Author

I did the limitation since there was one visible clef, and I didn't want the confusing case where two different clefs were encoded in the subspines.

It might be worth considering this case further. For example, in scriabin-op08_no12, I'm using hidden rests to avoid excessive merging and splitting (I would have to merge and split twice in every measure otherwise). In m. 40, the left hand moves to treble clef, but only in the right subspine. Ideally I would add *clefF4 in the left subspine to make this clear.

Screen Shot 2024-04-11 at 5 44 40 PM

If I add the *clefF4 the notes are correct, but both clefs are rendered on top of each other.

Screen Shot 2024-04-11 at 5 46 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vhv-viz-bug This issue concerns a bug in VHV visualization of kern.
Projects
None yet
Development

No branches or pull requests

2 participants