Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to standard linting #13

Closed
hiimbex opened this issue Sep 28, 2017 · 3 comments
Closed

Swap to standard linting #13

hiimbex opened this issue Sep 28, 2017 · 3 comments

Comments

@hiimbex
Copy link
Member

hiimbex commented Sep 28, 2017

Re: behaviorbot/welcome#8 updating to standard linting, which means: in the package.json changing:

"test": "mocha && xo --extend eslint-config-probot"

to mocha && standard and removing the unnecssary dependecnies here:
"devDependencies": {
"eslint-config-probot": "^0.1.0",
"expect": "^1.20.2",
"localtunnel": "^1.8.3",
"mocha": "^3.4.2",
"xo": "^0.18.2"
},
"xo": {
"space": 2
},
(xo and the eslint one). Then installing standard with npm install --save-dev standard and then running standard --fix to lint all things standard.

You will probably also need to add to the package.json this:

"standard": {
    "env": [
      "mocha"
    ]
  },

so that our tests can operate without linting errors.

Then run npm test to make sure everything works! Let me know if you have any questions.

@peterblazejewicz
Copy link
Contributor

FYI: This one is problematic, I've tried to fulfill an issue topic with current standard version from NPM and it is still subject of Error: Failed to load plugin import: Cannot find module 'eslint-plugin-import' problems described here:
standard/standard#949
Thanks!

@hiimbex
Copy link
Member Author

hiimbex commented Sep 28, 2017

Yep, I am aware of that issue, somewhat annoying 🙁 The solution is to either add npm install --save-dev eslint-plugin-import or simply use a different version of npm other than 5.2.0.

@peterblazejewicz
Copy link
Contributor

npm install --save-dev eslint-plugin-import

As you wish. The other option is somehow doomed. Done!

hiimbex added a commit that referenced this issue Sep 28, 2017
Swap to standard based linter. Closes #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants