Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on trivial changes #25

Open
strugee opened this issue Dec 1, 2017 · 4 comments
Open

Comments on trivial changes #25

strugee opened this issue Dec 1, 2017 · 4 comments

Comments

@strugee
Copy link

strugee commented Dec 1, 2017

See https://github.com/probot/metrics/pull/14#issuecomment-348615845 for an example of this - it's just a typo fix so I didn't provide a body.

@welcome
Copy link

welcome bot commented Dec 1, 2017

Thanks for opening this issue, a maintainer will get back to you shortly!

@hiimbex
Copy link
Member

hiimbex commented Apr 16, 2018

Sorry for the delay in getting back on this, but yes don't disagree that this sucks. Would happily review and merge a PR to check for the commit diff and anything less than a specified amount of lines in the config file (ie 5), the bot would not comment.

@itaditya
Copy link

@hiimbex I'll like to work on this

@itaditya
Copy link

@hiimbex, I was thinking about the possible solutions. One quick and dirty way would be to just check the count of characters in the diff file.
This method does have it's flaws, like renaming file can be a big deal however the diff char count will be small in this case.

I think I'll first make a basic version with this method and then improve upon it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants