Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to forbid generated title for edits done on github #24

Open
stof opened this issue Nov 13, 2017 · 6 comments
Open

Ability to forbid generated title for edits done on github #24

stof opened this issue Nov 13, 2017 · 6 comments

Comments

@stof
Copy link

stof commented Nov 13, 2017

When someone edits a file directly on github and does not fill a commit message, Github will fill it as Update <filename>, which then becomes the default PR title too.

It would be great to have an option to request more info for such title, without having to list all possible file names in the config.

@welcome
Copy link

welcome bot commented Nov 13, 2017

Thanks for opening this issue, a maintainer will get back to you shortly!

@hiimbex
Copy link
Member

hiimbex commented Nov 20, 2017

Sorry for the delay in responding to this. I'm +1 for this as an optional add-on. I've found that the app is a lot more useful in yelling at folks who leave the body empty as opposed to the titles, because the title is less indicative of if the body has the necessary information. Would you be interested in implementing this feature @stof? If not, it'll be on my backburner :)

@stof
Copy link
Author

stof commented Nov 20, 2017

@hiimbex I still think that the title is important (especially on big projects), as the body does not appear in the PR list.

How do you see this appearing in the configuration ? A boolean value sibling to the existing list of default titles ?

@hiimbex
Copy link
Member

hiimbex commented Nov 20, 2017

👍 that makes sense. and yes maybe something like:

requestInfoDefaultTitles:
  - update things
requestInfoAutomatedTitles: true

@aryannarora
Copy link
Contributor

This has been implemented right?

@aryannarora
Copy link
Contributor

Sorray, I misinterpreted it. I would like to add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants