Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Material Design 3 #1149

Closed
Wojtaz0w opened this issue Jun 30, 2023 · 12 comments
Closed

Update to Material Design 3 #1149

Wojtaz0w opened this issue Jun 30, 2023 · 12 comments
Labels
proposal A proposal for a new feature

Comments

@Wojtaz0w
Copy link

Hi. I updated Aegis to MD3 and it looks really good to me. This is my first commit to any Android app ever so please expect some beginner issues🙂I would also be very grateful if you would accept this - I spent a lot of time writing this. Here's the repo: https://github.com/Wojtaz0w/Aegis-MD3 and here are some screenshots.
obraz
obraz
obraz
obraz
@Wojtaz0w Wojtaz0w added the proposal A proposal for a new feature label Jun 30, 2023
@Wojtaz0w
Copy link
Author

duplicate of #842

but i actually started working on it

@Silther
Copy link

Silther commented Jul 28, 2023 •
edited
Loading

Sorry misread it

@ubionexd
Copy link

You should create a pull request.

@Wojtaz0w
Copy link
Author

You should create a pull request.

Soon™

@Wojtaz0w
Copy link
Author

I'm back!!!
Now Dialogs are rounded!!!
obraz

@Wojtaz0w
Copy link
Author

PR will be ready today!!

@ghost
Copy link

ghost commented Oct 4, 2023 •
edited by ghost
Loading

PR will be ready today!!

Any more progress on the PR?

@Wojtaz0w
Copy link
Author

Wojtaz0w commented Oct 4, 2023

I'm currently working on fixing bottom sheet corners. also i have school, so I think PR will be ready tomorrow or on Saturday.

@Wojtaz0w
Copy link
Author

Wojtaz0w commented Oct 7, 2023

#1208

@Wojtaz0w Wojtaz0w mentioned this issue Oct 7, 2023
Closed
@Wojtaz0w
Copy link
Author

Wojtaz0w commented Dec 3, 2023

FYI for everyone who's been interested:
My PR has been rejected. Not gonna lie, that really hurt me. Authors said they will "soon" begin integrating MD3 by themselves. I am considering creating and maintaining a fork which will be basically upstream Aegis with my patches. If that's desired by anyone please let me know.

@michaelschattgen
Copy link
Member

michaelschattgen commented Dec 3, 2023 •
edited
Loading

@Wojtaz0w We have been working on it. Here's the draft PR for Material 3: #1227 .

@Wojtaz0w
Copy link
Author

Wojtaz0w commented Dec 3, 2023

Oh. I didn't notice. Closing this issue then

@Wojtaz0w Wojtaz0w closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal A proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@michaelschattgen @ubionexd @Silther @Wojtaz0w