Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

JavaCC dependency has class in root package - causes OSGI build failure. #44

Open
pgwilliams opened this issue Jul 21, 2015 · 4 comments

Comments

@pgwilliams
Copy link

Resty currently has a dependency on javacc-4.1.jar which has classes in the root package. This causes a problem when used in an OSGI context where the construction of the manifest complains that: "The default package '.' is not permitted by the Import-Package syntax."

I checked the latest javacc-6.1.2.jar and it has the same issue, so no quick fix there I'm afraid.

@beders
Copy link
Owner

beders commented Jul 21, 2015

Hmm, maybe there is way to remove this dependency when generating the parser.
I’ll have a look.

On Jul 21, 2015, at 2:27 AM, Peter G. Williams [email protected] wrote:

Resty currently has a dependency on javacc-4.1.jar which has classes in the root package. This causes a problem when used in an OSGI context where the construction of the manifest complains that: "The default package '.' is not permitted by the Import-Package syntax."

I checked the latest javacc-6.1.2.jar and it has the same issue, so no quick fix there I'm afraid.


Reply to this email directly or view it on GitHub #44.

@pgwilliams
Copy link
Author

Hi Jochen, thanks for looking at this so quickly.
We forked your repo and - at runtime at least - it appears to work fine with the javacc dependency removed.
https://github.com/IHTSDO/Resty
If the parser is not generated every build, would moving that dependency into a profile help? http://stackoverflow.com/questions/166895/different-dependencies-for-different-build-profiles-in-maven
Best Wishes,Peter Williams
Date: Tue, 21 Jul 2015 08:05:37 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [Resty] JavaCC dependency has class in root package - causes OSGI build failure. (#44)

Hmm, maybe there is way to remove this dependency when generating the parser.

I’ll have a look.

On Jul 21, 2015, at 2:27 AM, Peter G. Williams [email protected] wrote:

Resty currently has a dependency on javacc-4.1.jar which has classes in the root package. This causes a problem when used in an OSGI context where the construction of the manifest complains that: "The default package '.' is not permitted by the Import-Package syntax."

I checked the latest javacc-6.1.2.jar and it has the same issue, so no quick fix there I'm afraid.

Reply to this email directly or view it on GitHub #44.


Reply to this email directly or view it on GitHub.

@beders
Copy link
Owner

beders commented Jul 21, 2015

I’ll make it a compile-time dependency.
Thank you for looking into it!

On Jul 21, 2015, at 8:43 AM, Peter G. Williams [email protected] wrote:

Hi Jochen, thanks for looking at this so quickly.
We forked your repo and - at runtime at least - it appears to work fine with the javacc dependency removed.
https://github.com/IHTSDO/Resty
If the parser is not generated every build, would moving that dependency into a profile help? http://stackoverflow.com/questions/166895/different-dependencies-for-different-build-profiles-in-maven
Best Wishes,Peter Williams
Date: Tue, 21 Jul 2015 08:05:37 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [Resty] JavaCC dependency has class in root package - causes OSGI build failure. (#44)

Hmm, maybe there is way to remove this dependency when generating the parser.

I’ll have a look.

On Jul 21, 2015, at 2:27 AM, Peter G. Williams [email protected] wrote:

Resty currently has a dependency on javacc-4.1.jar which has classes in the root package. This causes a problem when used in an OSGI context where the construction of the manifest complains that: "The default package '.' is not permitted by the Import-Package syntax."

I checked the latest javacc-6.1.2.jar and it has the same issue, so no quick fix there I'm afraid.

Reply to this email directly or view it on GitHub #44.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub #44 (comment).

@pgwilliams
Copy link
Author

Ahh, well that was in my best interest because we're getting very speedy implementation of a REST client using it - have done already in a previous project and now attempting the same thing with another project this time OSGI - so thank you for making that available for the greater good.
Best wishes,Peter

Date: Tue, 21 Jul 2015 10:24:23 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [Resty] JavaCC dependency has class in root package - causes OSGI build failure. (#44)

I’ll make it a compile-time dependency.

Thank you for looking into it!

On Jul 21, 2015, at 8:43 AM, Peter G. Williams [email protected] wrote:

Hi Jochen, thanks for looking at this so quickly.

We forked your repo and - at runtime at least - it appears to work fine with the javacc dependency removed.

https://github.com/IHTSDO/Resty

If the parser is not generated every build, would moving that dependency into a profile help? http://stackoverflow.com/questions/166895/different-dependencies-for-different-build-profiles-in-maven

Best Wishes,Peter Williams

Date: Tue, 21 Jul 2015 08:05:37 -0700

From: [email protected]

To: [email protected]

CC: [email protected]

Subject: Re: [Resty] JavaCC dependency has class in root package - causes OSGI build failure. (#44)

Hmm, maybe there is way to remove this dependency when generating the parser.

I’ll have a look.

On Jul 21, 2015, at 2:27 AM, Peter G. Williams [email protected] wrote:

Resty currently has a dependency on javacc-4.1.jar which has classes in the root package. This causes a problem when used in an OSGI context where the construction of the manifest complains that: "The default package '.' is not permitted by the Import-Package syntax."

I checked the latest javacc-6.1.2.jar and it has the same issue, so no quick fix there I'm afraid.

Reply to this email directly or view it on GitHub #44.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub #44 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants