Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving independency between batoms and batoms_api #7

Open
alchem0x2A opened this issue Jun 27, 2022 · 1 comment
Open

Improving independency between batoms and batoms_api #7

alchem0x2A opened this issue Jun 27, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@alchem0x2A
Copy link
Collaborator

Related to #5 . We should make the batoms main package and batoms_api as independent as possible. In a minimal content, we should allow user to:

  1. Only install batoms_api in her / his working environment, while batoms and blender is managed in another environment
  2. On the rendering part, only batoms is involved, no calls to batoms_api is needed

A possible solution is to add the script_api as a submodule of batoms which handles the .inp file through sys.argv, equivalent to

$BLENDER -b --python-expr "from batoms.script_api import run; run()" -- <path/to/.batoms.inp>

In this case, we can dump the schema dict into .batoms.inp, to avoid loading batoms_api and do version checking

@alchem0x2A alchem0x2A added the enhancement New feature or request label Jun 27, 2022
@alchem0x2A alchem0x2A self-assigned this Jun 27, 2022
@superstar54
Copy link
Member

Yes, I agree. It's a good solution to add script_api into batoms, and use batoms for all the rendering parts. The batoms_api is only used for generating the input file for batoms and calling batoms to run the jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants