Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to react 16 #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexdriaguine
Copy link

@alexdriaguine alexdriaguine commented Oct 21, 2018

I was thinking this package needs some love 😁 So I've updated it.

  • Uses create-react-library as build system. We can create bundles for different module types, deploy examples to gh-pages via create-react-app, testing via jest, bundling via rollup and many other goodies!
  • Remove external dependencies to ease-component and raf. requestAnimationFrame should not be something we have to polyfill, if users need it they can bundle their own. Also change the API so the easing function is bring your own. We provide one default and by allowing a easing prop as number => number, users can send in functions from their animation lib of choice
  • Support function as child (or render prop) for more control over the value
  • Bumped a major version since the changes are breaking

Some todos:

  • More thourough tests. I was thinking about using react-testing-library (not sure how one would test that it really animates, ideas? 🤔 )
  • Maybe some more good looking examples 😅

- refactor out dependencies
- use create-react-library
- support react 15 || 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant