You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is actually quite a bit of duplication of what's in Bamboo.Template, that could be cleaned up, along with adding assign/2 by doing the following in Bamboo.Phoenix:
importBamboo.Email
I'm glad to do a pull request if you guys agree with that solution. We could also just re-implement assign/2, but I would prefer not to duplicate the code.
Let me know your thoughts, thanks!
The text was updated successfully, but these errors were encountered:
Currently Bamboo.Phoenix only has the following
assign/3
function and not the typicalassign/2
:This makes it a little inconvenient to assign multiple values. It forces you to have to either implement
assign/2
yourself or do the following.It definitely surprised me and I have to spend a little time figuring out why the following wasn't working:
Shouldn't we have the same functions available as Bamboo.Template?
There is actually quite a bit of duplication of what's in
Bamboo.Template
, that could be cleaned up, along with addingassign/2
by doing the following inBamboo.Phoenix
:I'm glad to do a pull request if you guys agree with that solution. We could also just re-implement
assign/2
, but I would prefer not to duplicate the code.Let me know your thoughts, thanks!
The text was updated successfully, but these errors were encountered: