Don't use Serve! Please use ServeTLS or ListenAndServeTLS

[bddjr]

❌ Don't use Serve like this:

// Use hlfhr.New
srv := hlfhr.New(&http.Server{
	TLSConfig: &tls.Config{
		GetCertificate: func(chi *tls.ClientHelloInfo) (*tls.Certificate, error) {
			// Write something...
		},
	},
})
// Then just use it like [http.Server]

l, err := net.Listen("tcp", addr)
if err != nil {
	return err
}
defer l.Close()

l = tls.NewListener(l, config)
srv.Serve(l)

✅ Please use ServeTLS:

// Use hlfhr.New
srv := hlfhr.New(&http.Server{
	TLSConfig: &tls.Config{
		GetCertificate: func(chi *tls.ClientHelloInfo) (*tls.Certificate, error) {
			// Write something...
		},
	},
})
// Then just use it like [http.Server]

l, err := net.Listen("tcp", ":5678")
if err != nil {
	return err
}
defer l.Close()

srv.ServeTLS("", "")

✅ or use ListenAndServeTLS

// Use hlfhr.New
srv := hlfhr.New(&http.Server{
	Addr: ":5678",
	TLSConfig: &tls.Config{
		GetCertificate: func(chi *tls.ClientHelloInfo) (*tls.Certificate, error) {
			// Write something...
		},
	},
})
// Then just use it like [http.Server]

srv.ListenAndServeTLS("", "")

[bddjr]

For issue #4