Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data pipeline for LEAR table renaming and additional changes #334

Open
esune opened this issue Oct 10, 2023 · 9 comments
Open

Update data pipeline for LEAR table renaming and additional changes #334

esune opened this issue Oct 10, 2023 · 9 comments

Comments

@esune
Copy link
Member

esune commented Oct 10, 2023

The source database for LEAR is undergoing a refactoring that will require updates to the data pipeline responsible for ingesting records to be processed.

There are a few references of the businesses table in the code: https://github.com/search?q=repo%3Abcgov%2Fvon-bc-registries-agent%20businesses&type=code

Required changes include:

  • renaming the businesses table to entities
  • other?
@argush3
Copy link

argush3 commented Oct 17, 2023

I don't think the change will be as simple as renaming businesses to legal_entities.

I remember being asked about how LEAR versions data in the past so I am assuming that OrgBook processes are querying LEAR versioning tables. The new data model has adopted a new way of versioning data.

I've created a document that contains some of the details around the LEAR data model changes.

LEAR Data Model Changes.pdf

@ianco
Copy link
Contributor

ianco commented Oct 17, 2023

@argush3 what's the timeline on these changes being available in the dev or test environments (and expected timeline to promote into prod)?

@esune esune changed the title Update data pipelien for LEAR table renaming and additional changes Update data pipeline for LEAR table renaming and additional changes Oct 17, 2023
@argush3
Copy link

argush3 commented Oct 17, 2023

We are trying to wrap up development by the end of the month at which point we'll start integration testing.

When integration testing gets to a good enough place, we'll move things into the sandbox environment for a period of time that is still TBD(traditionally it's been 30 days). After sandbox we'll go to Prod.

Just for some additional context, we are in the process of moving all our LEAR BE pieces(including the database) to GCP. We already have an initial version of LEAR db in the GCP dev environment but we still need to get other BE services up and running.

We'll need to figure out the timing and how access to the new database will be given. I'll need to get back to you on this.

Also, the data conversion from old to new LEAR db still needs some work so it probably makes sense to wait until the data is closer to the intended end state to avoid re-work on your side.

So still a lot of moving pieces and things will change depending on how things play out based off of the things I mentioned above.

cc: @davemck513

@esune
Copy link
Member Author

esune commented Oct 17, 2023

Thank you @argush3. Please keep us posted so we can coordinate when to start development on our end.

@esune
Copy link
Member Author

esune commented Nov 2, 2023

@argush3 just a quick nudge to check whether you have a tentative timeline for this, as we'll need to coordinate our efforts/planning. If possible, if we could get access to a DB with the new data/structure sooner rather than later to start developing against it would be great.

@argush3
Copy link

argush3 commented Nov 3, 2023

We haven't been able to finish up the legal name updates and data fixes yet. I had to pivot a bit with other priorities so the timeline has extended out a bit. Will need to see when I can get back to the legal name work.

I'll talk to the team to see about providing access to the DB with the assumption that there will still be some model and data tweaks.

@esune
Copy link
Member Author

esune commented Nov 3, 2023

We haven't been able to finish up the legal name updates and data fixes yet. I had to pivot a bit with other priorities so the timeline has extended out a bit. Will need to see when I can get back to the legal name work.

I'll talk to the team to see about providing access to the DB with the assumption that there will still be some model and data tweaks.

Great, that would be very helpful - thanks @argush3 !

@swcurran swcurran moved this to Assigned in CDT Enterprise Apps Dec 19, 2023
@swcurran swcurran assigned Jsyro and esune and unassigned Jsyro Dec 19, 2023
@swcurran
Copy link
Contributor

Comment from @esune on ZenHub issue:

Access to the new LEAR db should be possible from the BC Registries Agent namespace, using a command like the following: psql -h gcp-lear-db-backup-dev.73c567-dev.svc -p 5432 -d legal-entities -U readonly.

TO be assessed whether we can connect to the db for schema exploration as-is, or we need additional permissions to the registries namespace.

@esune esune moved this from Assigned to In Progress in CDT Enterprise Apps Feb 5, 2024
@esune esune moved this from In Progress to Assigned in CDT Enterprise Apps Feb 12, 2024
@esune esune moved this from Assigned to Assignment Ready in CDT Enterprise Apps Feb 12, 2024
@esune esune removed their assignment Feb 12, 2024
@esune
Copy link
Member Author

esune commented Feb 12, 2024

On hold until data changes and migration is in a stable state, allowing us to work through the changes.

@esune esune moved this from Assignment Ready to Blocked in CDT Enterprise Apps Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

5 participants