wfnews-2407 #2106
Merged
wfnews-2407 #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utomatically adjust depending on the time of the year
yzlucas
changed the title
sukhpalp
requested changes
Oct 29, 2024
| const updateOptions: Intl.DateTimeFormatOptions = { | ||
| year: 'numeric', | ||
| month: 'long', | ||
| day: 'numeric', | ||
| hour: 'numeric', | ||
| minute: 'numeric', | ||
| second: undefined, // this removes the seconds | ||
| timeZone: 'America/Los_Angeles', // Pacific Time Zone |
There was a problem hiding this comment.
Do we need to specify timezone? If somebody was using this from the eastern parts of BC, they would be getting the wrong time zone as they are one hour ahead. Would it be enough just to get rid of the fixed PST?
There was a problem hiding this comment.
You are right, I forgot to consider some part of BC are off one hour.
Removed timezone option, thanks
sukhpalp
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PDT/PST suffix on a timestamp on the full details page needs to automatically adjust depending on the time of the year
https://apps.nrs.gov.bc.ca/int/jira/browse/WFNEWS-2407