-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: RPC endpoints with typesafety #1155, #1156 #1145
Open
kevin-hashimoto
wants to merge
49
commits into
release-0.2.0
Choose a base branch
from
feat/kevin-types
base: release-0.2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-hashimoto
requested review from
dhaselhan,
prv-proton,
hamed-valiollahi,
AlexZorkin and
areyeslo
and removed request for
dhaselhan and
prv-proton
October 31, 2024 19:19
Backend Test Results431 tests ±0 200 ✅ - 231 55s ⏱️ -37s For more details on these errors, see this check. Results for commit a231cbf. ± Comparison against base commit 66fbb2e. ♻️ This comment has been updated with latest results. |
kevin-hashimoto
changed the title
Feat: RPC endpoints with typesafety
Feat: RPC endpoints with typesafety #1155, #1156
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1155
closes #1156
Testing this PR
the best way to test this PR is probably to confirm each userflow and check if the features that involve the hooks work as expected.
context
When a file on the backend has changed, the backend watcher will generate a new openapi.json file. This openapi.json file is formatted in a standard spec that can be put through a generator to convert it into the necessary methods and types to use on the front end. Currently the frontend will need to manually run the generator via
npm run openapi:generate
but we are looking to incorporate a watcher that will watch the openapi.json file and run the generate script for full automation.Reach out if you have any questions!