Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ISO 639-2/639-5 collective codes #49

Open
sandbergja opened this issue Mar 7, 2023 · 1 comment · May be fixed by #50
Open

Feature request: ISO 639-2/639-5 collective codes #49

sandbergja opened this issue Mar 7, 2023 · 1 comment · May be fixed by #50

Comments

@sandbergja
Copy link
Contributor

sandbergja commented Mar 7, 2023

It would be helpful for my use case to be able to access the collective codes included in ISO 639-2 and ISO 639-5, without needing to use separate gems for ISO 639-2/5 and ISO 639-3.

For example, the following returns nil:

require 'languages'
Languages[:nah]
=> nil

Ideally, I would be able to do the following:

Languages[:nah].name
=> "Nahuatl languages"
Languages[:nah].alpha2
=> nil
Languages[:nah].alpha3_bibliographic
=> "nah"
Languages[:nah].type
=> :collective

I understand that these collective codes are not included in ISO 639-3, but it would be helpful to have them all in a single gem.

The collective codes can be found in a file here: http://id.loc.gov/vocabulary/iso639-5.tsv

@bbenno if this fits with the direction of the project, I'd be happy to create a PR for this feature.

@bbenno
Copy link
Owner

bbenno commented Mar 8, 2023

I think that is a great idea. I'd appreciate if you open a PR for it. Likewise, I am glad if I can support you in any case.

@sandbergja sandbergja linked a pull request Mar 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants