Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!(toolchain): remove uname dep in the repository_rule stage #2406

Merged
merged 16 commits into from
Nov 18, 2024
Merged

refactor!(toolchain): remove uname dep in the repository_rule stage #2406

merged 16 commits into from
Nov 18, 2024

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Nov 14, 2024

Before this PR we would shell out to uname on UNIX systems to get the arch
of the toolchain - on Windows we would not need to do it because there used to
be only a single Windows platform. With this change we can correctly support
the resolution of the python interpreter on various platforms and I have also
added an env variable to customize the selection, so that users can use musl
or a freethreaded interpreter if they wish.

As part of this change, I have restricted visibility of the config settings
used in the toolchain alias repo so that we are creating fewer targets. This is
a very good time to do this before 1.0.0.

Fixes #2145
Work towards #2276
Work towards #2386
Work towards #1211 to unblock #2402
Work towards #1361

@aignas aignas mentioned this pull request Nov 14, 2024
Open
4 tasks
rickeylev
rickeylev approved these changes Nov 17, 2024
View reviewed changes
python/private/toolchains_repo.bzl Outdated Show resolved Hide resolved
python/private/toolchain_aliases.bzl Outdated Show resolved Hide resolved
@aignas aignas added this pull request to the merge queue Nov 18, 2024
Merged via the queue into bazelbuild:main with commit 68d1b41 Nov 18, 2024
4 checks passed
@aignas aignas mentioned this pull request Nov 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2024
@aignas
feat(musl): add musl toolchain (#2402)
e7c306d 
With this and the previously landed #2406 users can use this in `sdist`
or `whl`-only setups alike. The PR itself is very simple and just adds
`musl` toolchains.

Whilst at it also move the `WhlLibc` flag out of the `pypi` namespace
since it is also used for `toolchain` matching now.

Fixes #1211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getting error indicating that uname is not in path on WSL
2 participants
@aignas @rickeylev