docs: rules_python bzlmod GA and 1.0 prep #2296
Conversation
|
Ran out of time today and this may contain some omissions, feel free to push here and reword things. |
| SHA="84aec9e21cc56fbc7f1335035a71c850d1b9b5cc6ff497306f84cced9a769841" | ||
|
|
||
| VERSION="0.23.1" | ||
| # Update the snippet based on the latest release below |
There was a problem hiding this comment.
nit: Are you sure about this change? I'm +1 on increasing to a newer version. Doesn't the extracted variables make it easier to bump versions in future? Or are you thinking there aren't major benefits to the indirection?
There was a problem hiding this comment.
I am thinking that one needs to copy the sha and version separately instead of just replacing the whole block of http_archive. If we had the indirection in the releases page, then sure, I think we should keep it, but the releases page does not have that.
What do you think?
There was a problem hiding this comment.
Oh right. Yes. If we could prepare a full copy-paste snippet somewhere that is kept up to date automatically, that would be cool. Im fine with your change.
There was a problem hiding this comment.
Yeah, the snippet is in the releases page, e.g. https://github.com/bazelbuild/rules_python/releases/tag/0.36.0
|
@rickeylev, I'll leave this open for you to have a chance to take a look. |
This is documenting the current state and closing the last remaining TODO items for 1.0 release. Work towards bazelbuild#1361.
Co-authored-by: Greg Roodt <[email protected]>
aignas
force-pushed
the
docs/prepare-1.0-1
branch
from
d166d47
to
e9f01d6
Compare
This is documenting the current state and closing the last remaining
TODO items for 1.0 release.
Work towards #1361.