Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python coverage #2248

Open
comius opened this issue Sep 25, 2024 · 1 comment
Open

Python coverage #2248

comius opened this issue Sep 25, 2024 · 1 comment
Labels
need: repro Needs a minimal reproduction

Comments

@comius
Copy link
Contributor

comius commented Sep 25, 2024

Upgrading rules_python in Bazel and running tests again version 0.36.0 showed problems with coverage support.

To reproduce run bazel test //src/test/shell/bazel:bazel_coverage_hermetic_py_test from Bazel repository. It fails saying the test has failed, but this previously with builtin Python rules wasn't the case.

I went down the rabbit hole, but I couldn't figure it out. I think that this test should be moved out of Bazel into rules_python, if it isn't already.

@rickeylev
Copy link
Collaborator

I synced my bazel repo to head and ran that test -- it passed. Was a change made elsewhere in bazel to fix it?

And yes, deleting it from Bazel makes sense

@aignas aignas added the need: repro Needs a minimal reproduction label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need: repro Needs a minimal reproduction
Projects
None yet
Development

No branches or pull requests

3 participants