Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue that the thinned dynamic frameworks would be overwritten by strip_bitcode. #2395

Closed
wants to merge 1 commit into from
Closed

Fix the issue that the thinned dynamic frameworks would be overwritten by strip_bitcode. #2395

wants to merge 1 commit into from

Conversation

xiemotongye
Copy link

Fix #2392

@xiemotongye xiemotongye mentioned this pull request Feb 8, 2024
Closed
@xiemotongye
Copy link
Author

xiemotongye commented Feb 8, 2024 •
edited
Loading

The tests for xcframework arm64e could be passed previously because the strip_bitcode overwrote the thinned binary to a fat binary.

So I think there may be some other issue in xcframework rules for arm64e.

@xiemotongye xiemotongye changed the title Fix the issue that the thinned dynamic library files would be overwritten by strip_bitcode. Fix the issue that the thinned dynamic frameworks would be overwritten by strip_bitcode. Feb 8, 2024
@keith
Copy link
Member

keith commented Feb 8, 2024

looks like the arm64e issue is bazelbuild/apple_support#301

@keith
Copy link
Member

keith commented Feb 9, 2024

thanks for submitting this! I took your fix into #2398 which also fixes the tests, please reopen your issue if it didn't fix this!

@keith keith closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dynamic frameworks won't strip archs since version 3.0.0
2 participants
@xiemotongye @keith