Don't break 12e+34 into 12e + 34
#1309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
fmeum
force-pushed
the
signed-exponent
branch
from
bc4a551 to
025cbb6
Compare
vladmos
reviewed
Nov 27, 2024
| -1e6, | ||
| -1.23e-45, | ||
| 3.539537889086625e+24, | ||
| 3.539537889086625E+24, |
There was a problem hiding this comment.
I wonder if buildifier should default to lowercase e and no plus sign for positive exponents (that's what pyformat does).
There was a problem hiding this comment.
Yes, I think it makes sense to standardize this. Changing to lowercase e can affect existing users (so it's worth mentioning in the release notes), but it should be easy to rollout.
vladmos
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.