Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildifer 2 support byte string and load comments #1049

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Buildifer 2 support byte string and load comments #1049

wants to merge 5 commits into from

Conversation

emcfarlane
Copy link

@emcfarlane emcfarlane commented Feb 16, 2022 •
edited
Loading

Adds support in buildifer2 for comments on load statements and support for byte strings.

Bytes was added to starlark-go here: google/starlark-go#330

@emcfarlane
Copy link
Author

What's the correct way to get the hash of a golang module dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmos vladmos Awaiting requested review from vladmos vladmos is a code owner

@pmbethe09 pmbethe09 Awaiting requested review from pmbethe09 pmbethe09 is a code owner

@meisterT meisterT Awaiting requested review from meisterT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emcfarlane