Fail on inapplicable flags on non-common commands expanded from configs #23105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
fmeum
force-pushed
the
22980-options-parsing
branch
from
0146e48
to
da25a03
Compare
fmeum
force-pushed
the
22980-options-parsing
branch
from
da25a03
to
1845f82
Compare
github-actions
bot
added
the
awaiting-review
fmeum
commented
Jul 25, 2024
justinhorvitz
requested changes
Jul 25, 2024
src/main/java/com/google/devtools/common/options/OptionsParserImpl.java
Outdated
Show resolved
Hide resolved
| if (!args.isEmpty() && args.get(0).startsWith("@")) { | ||
| public List<ArgAndFallbackData> preProcess(List<ArgAndFallbackData> args) | ||
| throws OptionsParsingException { | ||
| if (!args.isEmpty() && args.getFirst().arg.startsWith("@")) { |
There was a problem hiding this comment.
I don't think you can use getFirst() in this file given the java 11 thing.
There was a problem hiding this comment.
This actually doesn't break CI since the bootclasspath is determined by the Java runtime version, not the language level. But it would break the consumers that legitimately build with a JDK 11, so good catch on your part.
@cushon @hvadehra Since this is coming up in Bazel code, what do you think of reinvigorating bazelbuild/rules_java#182?
There was a problem hiding this comment.
I won't take credit, a breakage popped up when I imported.
src/main/java/com/google/devtools/common/options/OptionsParserImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/common/options/OptionsParser.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
22980-options-parsing
branch
from
1b3b4f5
to
83366ed
Compare
justinhorvitz
requested changes
Jul 25, 2024
src/main/java/com/google/devtools/build/lib/runtime/ConfigExpander.java
Outdated
Show resolved
Hide resolved
|
@bazel-io fork 7.3.0 |
justinhorvitz
approved these changes
Jul 25, 2024
iancha1992
added
team-Core
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jul 29, 2024
This regressed in bazelbuild@44d3953. Fixes bazelbuild#22980 Closes bazelbuild#23105. PiperOrigin-RevId: 657276908 Change-Id: If2e88455a344082bfbec405c30c148c0d044adb6
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Aug 19, 2024
This regressed in bazelbuild@44d3953. Fixes bazelbuild#22980 Closes bazelbuild#23105. PiperOrigin-RevId: 657276908 Change-Id: If2e88455a344082bfbec405c30c148c0d044adb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in 44d3953.
Fixes #22980