Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #3263

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @yuyawk, modules you maintain (rules_build_error) have been updated in this PR. Please review the changes.

yuyawk
yuyawk previously approved these changes Nov 26, 2024
Copy link
Contributor

@yuyawk yuyawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meteorcloudy
FYI, this new version 0.7.0 addresses your issue #3260

bazel-io
bazel-io previously approved these changes Nov 26, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy
Copy link
Member

Please take a look at the build failure

@bazel-io bazel-io dismissed stale reviews from yuyawk and themself November 26, 2024 13:27

Require module maintainers' approval for newly pushed changes.

@yuyawk
Copy link
Contributor

yuyawk commented Nov 26, 2024

Please take a look at the build failure

I did, but to be honest I have no idea about its cause. I'm not even sure if that's a persistent issue, or if that's triggered by the change in rules_build_error.
Mac OS usages are already tested with github-hosted runners and cannot reproduce the build error there, so I guess there's a gap between the buildkite environment and github-hosted runners.

With several versions rules_build_error has been tested with Mac OS, but this is the first time to see that /private/var/tmp/_bazel_buildkite (No such file or directory) error.

yuyawk
yuyawk previously approved these changes Nov 26, 2024
bazel-io
bazel-io previously approved these changes Nov 26, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

meteorcloudy
meteorcloudy previously approved these changes Nov 26, 2024
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 26, 2024
@bazel-io bazel-io dismissed stale reviews from yuyawk, meteorcloudy, and themself November 26, 2024 15:02

Require module maintainers' approval for newly pushed changes.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy merged commit c25496f into bazelbuild:main Nov 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants