Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: expand_template should support replacements, stamping #431

Closed
alexeagle opened this issue May 14, 2023 · 1 comment
Closed

[FR]: expand_template should support replacements, stamping #431

alexeagle opened this issue May 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working untriaged Requires traige

Comments

@alexeagle
Copy link
Collaborator

What happened?

We depend on a private one here
https://github.com/aspect-build/rules_js/blob/main/js/private/expand_template.bzl#L115
in some Aspect projects and some of our clients, because it's such a useful utility.

It lives in rules_js because @gregmagolan needed to write a process to perform an action.

It ought to come from bazel-lib instead. Like copy_to_directory, we should port that JS program to a minimal Go program to perform the action, and distribute it as a pre-built toolchain.

Note, bazelbuild/bazel-skylib#442 asks for the same thing on bazel-skylib

Version

HEAD

How to reproduce

No response

Any other information?

No response

@alexeagle alexeagle added the bug Something isn't working label May 14, 2023
@github-actions github-actions bot added the untriaged Requires traige label May 14, 2023
@thesayyn
Copy link
Collaborator

fixed by #435

@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

3 participants