Implement EpisodeChart.tsx #807
Open
+778
−435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desperationis
requested review from
lowtorola and
acrantel
and removed request for
lowtorola
|
@Desperationis see how the charts don't fill the section card? Is this how they look on your end? 
|
lowtorola
reviewed
May 13, 2024
lowtorola
reviewed
May 13, 2024
lowtorola
reviewed
May 13, 2024
lowtorola
reviewed
May 13, 2024
lowtorola
reviewed
May 13, 2024
|
Hi Lowell, thanks for the feedback. I'm a little hosed studying for finals right now but once that is settled I'll do the tweaks |
Merged
lowtorola
force-pushed
the
diego-charting
branch
2 times, most recently
from
11bb609
to
3b495c1
Compare
lowtorola
force-pushed
the
diego-charting
branch
from
d153add
to
12c99a0
Compare
|
@acrantel after hitting my head against the django wall for a few days this is actually ready for review 😎 |
|
oh also closes #844 because i forgot to split into two prs |
lowtorola
force-pushed
the
diego-charting
branch
from
12c99a0
to
a80a5e1
Compare
nour-massri
reviewed
Nov 23, 2024
rating api glowup added chart to userprofile
lowtorola
force-pushed
the
diego-charting
branch
from
a80a5e1
to
adc383c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EpisodeChartis a component that usesTeamChartto display the top 10 teams in any given year. I also added one more prop toTeamChartto take in tournament dates. I'll implementEpisodeChartautomatically listing tournament dates later, for now there is only placeholder code that shows up inbc22.Closes #783 🚀