Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier Page Loading #789

Open
lowtorola opened this issue Apr 30, 2024 · 0 comments · May be fixed by #854
Open

Prettier Page Loading #789

lowtorola opened this issue Apr 30, 2024 · 0 comments · May be fixed by #854
Assignees
@lowtorola
Labels
module: frontend Related to the Siarnaq frontend module priority: p3 low type: feature New feature or request, or quick non-essential bugfix
Milestone
Frontend2 Alpha

Comments

@lowtorola
Copy link
Contributor

lowtorola commented Apr 30, 2024 •
edited
Loading

Currently when certain pages are loading (including the MyTeam.tsx page) they simply render a spinner with loading text. It is preferred for pages to support loading for individual components instead. To do this, we should add a loading prop to the SectionCard component which displays a lovely loading icon in the middle of the card (responsive ui, etc.).
@lowtorola lowtorola added type: feature New feature or request, or quick non-essential bugfix module: frontend Related to the Siarnaq frontend module priority: p3 low labels Apr 30, 2024
@lowtorola lowtorola added this to the Frontend2 Alpha milestone Apr 30, 2024
@lowtorola lowtorola changed the title Prettier Loading for My Team Page Prettier Page Loading Sep 25, 2024
@lowtorola lowtorola linked a pull request Nov 22, 2024 that will close this issue
Open
@lowtorola lowtorola self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowtorola lowtorola

Labels
module: frontend Related to the Siarnaq frontend module priority: p3 low type: feature New feature or request, or quick non-essential bugfix
Projects
None yet
Milestone
Frontend2 Alpha
Development

Successfully merging a pull request may close this issue.

Prettier Loading battlecode/galaxy
1 participant
@lowtorola