Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs do not obey browser forward/back #1

Open
Inventsable opened this issue Apr 26, 2020 · 0 comments
Open

Tabs do not obey browser forward/back #1

Inventsable opened this issue Apr 26, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Inventsable
Copy link
Member

Leaving this here so I don't forget to fix it. To recreate, open the API and click on a few tabs. Notice that when you press browser forward/back, the routes obey this and you navigate between routes but the active Tab never changes.

Should fix with a watch prop on the current route and some regex detection -- shouldn't rely on path alone in case complex route parameters or nested routes are being used.

@Inventsable Inventsable changed the title Tabs component does not obey browser forward/back Tabs does not obey browser forward/back Apr 26, 2020
@Inventsable Inventsable changed the title Tabs does not obey browser forward/back Tabs do not obey browser forward/back Apr 26, 2020
@Inventsable Inventsable added the enhancement New feature or request label Apr 27, 2020
@Inventsable Inventsable self-assigned this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant