Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful error in depthNumbering #4

Open
AndreasVoellmy opened this issue Mar 23, 2015 · 2 comments
Open

Unhelpful error in depthNumbering #4

AndreasVoellmy opened this issue Mar 23, 2015 · 2 comments

Comments

@AndreasVoellmy
Copy link

If you apply depthNumbering starting from a root vertex that is not in the graph, you get the error:

Data.Graph.Wrapper.fromList: one of the edges of a vertex pointed to a vertex that was not supplied in the input

This suggests that the problem is fromList. However, the problem is really caused by a call to indexGVertex in depthNumbering. fromList has nothing to do with the problem.

I'm not sure what the ideal resolution is... at the least, it might be good to not mention fromList in the error message.

@soenkehahn
Copy link
Contributor

I'm maintaining graph-wrapper now: https://github.com/soenkehahn/graph-wrapper
But I guess we can keep this issue here.

I think depthNumbering should just ignore non-existing roots. @AndreasVoellmy: Would you agree?

(cc: @batterseapower)

@soenkehahn
Copy link
Contributor

I've created a PR: soenkehahn#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants