You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wondering if you would consider a PR that added a new environment variable to disable logs for HTTP requests sent upstream? Or all logs, if you wanted it more coarse.
I'm running thruster & puma with a Rails application in kubernetes, with probes turned on. That's pinging my healthcheck endpoint a lot. I can disable the logs within Rails, but I don't see a way to stop the logs from thruster itself.
I already have logs from the Rails code that has the information I care about, so the log message from thruster are repetitious for me.
The text was updated successfully, but these errors were encountered:
@nogweii yes, that's a great idea, thanks for bringing it up. I agree that the request logs can be superfluous in some cases.
I'd lean towards keeping any other logs, in case we need to emit something important, but being able to silence the request logs seems useful. So maybe we can support something like LOG_REQUESTS=false which prevents the logging middleware from being loaded. Default would be to log the requests, as we do now.
Happy to look at a PR for this!
nogweii
added a commit
to nogweii/thruster
that referenced
this issue
Nov 14, 2024
Adds an environment variable, $LOG_REQUESTS, that when set to a falsey
value will not add the logging middleware to the HTTP handler, disabling
request logs. Other logs, like the startup messages, are left alone.
Closesbasecamp#49.
Wondering if you would consider a PR that added a new environment variable to disable logs for HTTP requests sent upstream? Or all logs, if you wanted it more coarse.
I'm running thruster & puma with a Rails application in kubernetes, with probes turned on. That's pinging my healthcheck endpoint a lot. I can disable the logs within Rails, but I don't see a way to stop the logs from thruster itself.
I already have logs from the Rails code that has the information I care about, so the log message from thruster are repetitious for me.
The text was updated successfully, but these errors were encountered: