Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue (#1405) #1408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue (#1405) #1408

wants to merge 1 commit into from

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Dec 17, 2024

Description

This PR addresses issue #1405 by improving the setup.sh script with better error handling and safety measures.

Changes made:

  • Added proper error handling with informative messages for all critical commands
  • Improved environment variables handling using ${VAR:-DEFAULT} syntax for BUILDKITE variables
  • Added yarn.lock file existence check before running yarn --immutable
  • Added proper error handling for git fetch command
  • Enclosed all variable references in quotes for safe handling of special characters
  • Added -u flag to set command to catch undefined variables

Testing:

The script has been tested for the following scenarios:

  • Missing yarn.lock file
  • Failed yarn build
  • Missing BUILDKITE environment variables
  • Failed git fetch

These improvements make the script more robust and easier to debug when issues occur.

Fixes #1405

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:48am

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024

@crStiv is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns wbnns added community contribution base web review To be reviewed by the Base web team and removed community contribution labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs Request: Corrections to improve /setup.sh script
3 participants
@crStiv @cb-heimdall @wbnns