[Fix] Patch minor #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkitlabs
requested review from
RogerKSI and
tanut32039
and removed request for
RogerKSI
RogerKSI
reviewed
Dec 17, 2024
| // 3. log-level from configuration object. | ||
| // 4. given log level from the input. | ||
| logLevel := configLogLevel | ||
| logLevelViper := a.Viper.GetString("log-level") |
There was a problem hiding this comment.
Is there any reason why we choose to send viper in instead of handling value from cmd?
Comment on lines
+167
to
+172
|
|
||
| // check if file doesn't exist, exit the function as the config may not be initialized. | ||
| if _, err := os.Stat(cfgPath); os.IsNotExist(err) { | ||
| return nil | ||
| } else if err != nil { | ||
| return err |
There was a problem hiding this comment.
Is it a bit weird to return no-error if the config file doesn't exist? caller will need to check from the variable only to see if it can load successfully.
| @@ -211,13 +221,17 @@ func (a *App) InitConfigFile(homePath string, customFilePath string) error { | |||
| if err = os.Mkdir(homePath, os.ModePerm); err != nil { | |||
| return err | |||
| } | |||
| } else if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| // Create the config folder if doesn't exist | |||
| if _, err := os.Stat(cfgDir); os.IsNotExist(err) { | |||
| if err = os.Mkdir(cfgDir, os.ModePerm); err != nil { | |||
There was a problem hiding this comment.
also, maybe we can create helper function to create folder if it doesn't exist.
Comment on lines
577
to
580
| if len(tunnels) == 0 { | ||
| a.Log.Error("No tunnel ID provided") | ||
| return fmt.Errorf("no tunnel ID provided") | ||
| } |
There was a problem hiding this comment.
it also can happen when run with just start command but there's no tunnel on chain?
There was a problem hiding this comment.
for that case, we should not return error.
| @@ -99,7 +98,7 @@ func (c *client) Connect(timeout uint) error { | |||
| return nil | |||
| } | |||
|
|
|||
| return nil | |||
| return fmt.Errorf("failed to connect to Band Chain") | |||
Comment on lines
+73
to
+77
| // Return if there are no RPC endpoints | ||
| if len(c.RpcEndpoints) == 0 { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
why choose to return nil? no endpoints mean can't connect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)