Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resin.models.device.ensureSupervisorCompatibility(): add tests and handle invalid semver versions gracefully #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

resin.models.device.ensureSupervisorCompatibility(): add tests and handle invalid semver versions gracefully #227

wants to merge 1 commit into from

Conversation

lekkas
Copy link
Contributor

@lekkas lekkas commented Sep 27, 2016 •
edited
Loading

Closes #222

Page-
Page- previously approved these changes Sep 27, 2016
View reviewed changes
@lekkas lekkas force-pushed the 222-handle-invalid-semver-versions-gracefully branch from eaf160b to 18e0d80 Compare September 27, 2016 18:47
@lekkas
Copy link
Contributor Author

lekkas commented Sep 27, 2016

Tests fail with

 AssertionError: expected promise to be rejected with an error including 'No such device type' but got 'Request error: Device type "foo-bar-baz" not found'

TIL that resin-sdk actually uses the real thing during testing.

@Page-
Copy link
Contributor

Page- commented Sep 27, 2016

Yeah, I PRed #219 when I found out that :P

@lekkas
Copy link
Contributor Author

lekkas commented Sep 28, 2016

If it wasn't for the warning I'd definitely have used my own account :P

@pcarranzav
Copy link
Contributor

@Page- @lekkas I PRd #230 to make the tests work again

@lekkas lekkas force-pushed the 222-handle-invalid-semver-versions-gracefully branch from 18e0d80 to 45438ab Compare October 26, 2016 16:13
@kaisoz kaisoz added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Jun 10, 2020
@ghost ghost dismissed Page-’s stale review June 10, 2020 14:22

Approval reviews not allowed in Draft PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Page- Page- Page- left review comments

Assignees
No one assigned
Labels
versionbot/pr-draft Draft PR - Don't merge this PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle invalid semver versions gracefully when checking HostOS and/or Supervisor versions
4 participants
@lekkas @Page- @pcarranzav @kaisoz