Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SauceLabs or BrowserStack tests #238

Closed
emirotin opened this issue Dec 13, 2016 · 6 comments
Closed

Add SauceLabs or BrowserStack tests #238

emirotin opened this issue Dec 13, 2016 · 6 comments

Comments

@emirotin
Copy link
Contributor

We need to test this module (and ideally lower-level sub-modules) in the real browsers. PhantomJS is OK to check the compatibility with generic browser environment, but it's not the real browser.

I've recently hit a bug where Chrome had different implementation of some internal property.

@jviotti
Copy link
Contributor

jviotti commented Dec 13, 2016

Could https://github.com/resin-io-modules/resin-config-karma be useful here?

@emirotin
Copy link
Contributor Author

emirotin commented Dec 13, 2016 via email

@jviotti
Copy link
Contributor

jviotti commented Dec 13, 2016

We do use SauceLabs for resin-config-karma. See https://github.com/resin-io-modules/resin-config-karma/blob/master/launchers.json for the list of browsers this will run against.

@jviotti
Copy link
Contributor

jviotti commented Dec 13, 2016

Feel free to tweak the list of browsers we should support!

@emirotin
Copy link
Contributor Author

emirotin commented Dec 13, 2016 via email

@thgreasi
Copy link
Member

Closing in favor of using balenaCI.
See: #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants