Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iso images #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support iso images #12

wants to merge 2 commits into from

Conversation

zvin
Copy link
Contributor

@zvin zvin commented Feb 16, 2017

This PR also moves src/linux to vendor/linux and adds a defconfig.patch that will be applied to vendor/linux/arch/lkl/defconfig.

@zvin zvin requested a review from petrosagg February 16, 2017 16:13
@lurch
Copy link
Contributor

lurch commented Feb 16, 2017

Does it make sense to include both these commits in a single PR?

@zvin
Copy link
Contributor Author

zvin commented Feb 16, 2017

They don't have to be in the same PR but I see no harm in grouping them.

@zvin
Copy link
Contributor Author

zvin commented Feb 16, 2017

I am more concerned by the fact that vendor.sh always gets the latest master branch of lkl.
So the second commit ( a854d27 ) not only adds support for udf and iso9660 but also updates lkl.
Maybe we should use a tag or a specific commit in vendor.sh ?

@zvin
Copy link
Contributor Author

zvin commented Feb 16, 2017

Maybe we can use lkl linux as a git submodule and stop copying it.
So we don't have to manually add each source file used by make when we update the defconfig?
What do you think @petrosagg ?

@zvin zvin force-pushed the support-iso-images-2 branch 2 times, most recently from 87efc09 to 9a33409 Compare March 31, 2017 17:24
@zvin zvin force-pushed the support-iso-images-2 branch from 9a33409 to ab8866d Compare April 6, 2017 14:42
Copy link
Contributor

@petrosagg petrosagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No-op review to dismiss stale review request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants